Patrick McHardy wrote: > Wolfgang Grandegger wrote: >> David Miller wrote: >>> From: Wolfgang Grandegger <[email protected]> >>> Date: Sat, 07 Nov 2009 10:53:13 +0100 >>> >>>> On older kernels, e.g. 2.6.27, a WARN_ON dump in rtmsg_ifinfo() >>>> is thrown when the CAN device is registered due to insufficient >>>> skb space, as reported by various users. This patch adds the >>>> rtnl_link_ops "get_size" to fix the problem. I think this patch >>>> is required for more recent kernels as well, even if no WARN_ON >>>> dumps are triggered. Maybe we also need "get_xstats_size" for >>>> the CAN xstats. >>>> >>>> Signed-off-by: Wolfgang Grandegger <[email protected]> >>> Applied to net-2.6, thanks Wolfgang. >> Thanks, the commit message included some questions. What is the rule >> using the rtnl_link_ops "get_size" or "get_xstats_size". Are these >> mandatory if the corresponding fill functions are used? > > Yes. You also need a get_xstats_size() function.
Thanks for clarification. I will provide a patch a.s.a.p. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
