Marc Kleine-Budde wrote:
> Wolfram Sang wrote:
>>>> +struct esd_usb2_net {
>>>> + struct can_priv can; /* must be the first member */
>>>> +
>>>> + atomic_t active_tx_urbs;
>>>> + struct usb_anchor tx_submitted;
>>>> + struct esd_tx_urb_context tx_contexts[MAX_TX_URBS];
>>>> +
>>>> + int open_time;
>>>> + struct esd_usb2 *usb2;
>>>> + struct net_device *netdev;
>>>> + int index;
>>>> + u8 old_state;
>>>> +};
>>> you might want to add tabs between the type and the variable in these
>>> struct in order to align them.
>> NACK. If another member is added later having a longer name, _all_ the
>> members
>> have to be realigned. That pollutes the history with whitespace-fixes IMO.
>
> I said Wolfgang the same for my driver...
In general, *no* alignment of variables, members, expressions, please.
With the at91_can it was different. All defines and members of
structures have been aligned nicely in the file header, but just one.
Wolfgang.
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
