Thomas Körper wrote:
> Hi,
>
>>> stats->tx_dropped++;
>>> dev_kfree_skb(skb);
>> s/dev_kfree_skb/kfree_skb/
> Hm?
We had some discussion on what to use in the xmit function recently.
>> Also, how can it happen that the FIFO is full? As I see it,
>> only esd331_start_xmit() is writing to the FIFO one message at the time.
> Ah, that's right! So this should never happen and we'll just drop then:
>
> can_put_echo_skb(skb, dev, 0);
> if (unlikely(esd331_write(&msg, priv->board))) {
> can_free_echo_skb(dev, 0);
> stats->tx_dropped++;
> return NETDEV_TX_OK;
> }
Yes. As this event is not expected to happen, an error message would
make sense here.
Wolfgang.
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
