Daniel Baluta wrote: > Check the return value of device_create_file to make gcc happy. > > Signed-off-by: Daniel Baluta <[email protected]> > Reported-by: Thorsten Godau <[email protected]> > --- > -- drivers/net/can/usb/esd_usb2.c.orig 2010-02-14 19:24:37.000000000 > +0200 > +++ drivers/net/can/usb/esd_usb2.c 2010-02-14 20:00:51.000000000 +0200 > @@ -1038,9 +1038,17 @@ static int esd_usb2_probe(struct usb_int > dev->version = le32_to_cpu(msg.msg.version_reply.version); > > #ifdef CONFIG_SYSFS > - device_create_file(&intf->dev, &dev_attr_firmware); > - device_create_file(&intf->dev, &dev_attr_hardware); > - device_create_file(&intf->dev, &dev_attr_nets); > + if (device_create_file(&intf->dev, &dev_attr_firmware)) > + dev_err(&intf->dev, > + "Couldn't create device file for firmware\n"); > + > + if (device_create_file(&intf->dev, &dev_attr_hardware)) > + dev_err(&intf->dev, > + "Couldn't create device file for hardware\n"); > + > + if (device_create_file(&intf->dev, &dev_attr_nets)) > + dev_err(&intf->dev, > + "Couldn't create device file for nets\n"); > #endif > > /* do per device probing */
The patch is fine... applied. BTW: we have two more broken drivers in SVN trunk, at least. The ems_pcmcia and the softing drivers do not compile any more with recent kernel version. I added the maintainers to the CC. Thanks, Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
