Sriramakrishnan wrote: > CAN module on AM3517 requires programming of IO expander as part > of init sequence - to enable CAN PHY. Added platform specific > callback to handle phy control(switch on /off). > > Signed-off-by: Sriramakrishnan <[email protected]>
looks good, just minor nitpicking inline
Cheers, Marc
> ---
> Modified as per review comments received.
>
> drivers/net/can/ti_hecc.c | 15 ++++++++++++++-
> include/linux/can/platform/ti_hecc.h | 3 ++-
> 2 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
> index df27d82..871a3fe 100644
> --- a/drivers/net/can/ti_hecc.c
> +++ b/drivers/net/can/ti_hecc.c
> @@ -28,9 +28,11 @@
> * .mbx_offset = 0x2000,
> * .int_line = 0,
> * .revision = 1,
> + * .transceiver_switch = hecc_phy_control,
> * };
> *
> - * Please see include/can/platform/ti_hecc.h for description of above fields
> + * Please see include/linux/can/platform/ti_hecc.h for description of
> + * above fields.
> *
> */
>
> @@ -220,6 +222,7 @@ struct ti_hecc_priv {
> u32 tx_head;
> u32 tx_tail;
> u32 rx_next;
> + void (*transceiver_switch)(int);
> };
>
> static inline int get_tx_head_mb(struct ti_hecc_priv *priv)
> @@ -317,6 +320,13 @@ static int ti_hecc_set_btc(struct ti_hecc_priv *priv)
> return 0;
> }
>
> +static void ti_hecc_transceiver_switch(const struct ti_hecc_priv *priv,
> + int on)
> +{
> + if (priv->transceiver_switch)
> + priv->transceiver_switch(on);
> +}
> +
> static void ti_hecc_reset(struct net_device *ndev)
> {
> u32 cnt;
> @@ -824,6 +834,7 @@ static int ti_hecc_open(struct net_device *ndev)
> return err;
> }
>
> + ti_hecc_transceiver_switch(priv, 1);
> ti_hecc_start(ndev);
> napi_enable(&priv->napi);
> netif_start_queue(ndev);
> @@ -840,6 +851,7 @@ static int ti_hecc_close(struct net_device *ndev)
> ti_hecc_stop(ndev);
> free_irq(ndev->irq, ndev);
> close_candev(ndev);
> + ti_hecc_transceiver_switch(priv, 0);
nitpick: it's not symetric to the _start function.
>
> return 0;
> }
> @@ -901,6 +913,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
> priv->hecc_ram_offset = pdata->hecc_ram_offset;
> priv->mbx_offset = pdata->mbx_offset;
> priv->int_line = pdata->int_line;
> + priv->transceiver_switch = pdata->transceiver_switch;
>
> priv->can.bittiming_const = &ti_hecc_bittiming_const;
> priv->can.do_set_mode = ti_hecc_do_set_mode;
> diff --git a/include/linux/can/platform/ti_hecc.h
> b/include/linux/can/platform/ti_hecc.h
> index 4688c7b..825bc6a 100644
> --- a/include/linux/can/platform/ti_hecc.h
> +++ b/include/linux/can/platform/ti_hecc.h
> @@ -23,6 +23,7 @@
> * @mbx_offset: Mailbox RAM offset
> * @int_line: Interrupt line to use - 0 or 1
> * @version: version for future use
> + * @transceiver_switch platform specific callback fn for transceiver control
^^
nitpick:
these are spaces, but the other lines use tabs
> *
> * Platform data structure to get all platform specific settings.
> * this structure also accounts the fact that the IP may have different
> @@ -35,6 +36,6 @@ struct ti_hecc_platform_data {
> u32 mbx_offset;
> u32 int_line;
> u32 version;
> + void (*transceiver_switch) (int);
> };
>
> -
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
