Hello, we have a nasty mistake in the clock setup code of the SJA1000 platform driver. The member "clock" of "struct sja1000_platform_data" is documented as "CAN bus oscillator frequency in Hz" but in the probe function we assign:
priv->can.clock.freq = pdata->clock; In fact, it should be "pdata->clock/2", but that would require fixing platform code as well. To avoild confusion, we should at least fix the documentation. A clean fix would rename the member to "osc_freq", assign "pdata->osc_freq/2" and fix the relevant platform code. What do you think? Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
