Wolfgang Grandegger wrote: >>>> It's available as a git tree at: >>>> http://git.pengutronix.de/?p=mkl/berlios-can-utils.git;a=shortlog;h=refs/heads/rfc/better-bitrate-calculation >>> Looks good at a first glance and they could go in immediately. We can >>> add fixes later on, if necessary. One requirement of the algorithm is >>> that it *must* reproduce the CIA recommanded values for the SJA1000 for >>> the standard bit-rates. We should not expect that it works for any >> Have a look at patch 5. In it's patch description is a diff of output of >> the original and the improved version. As you can see no changes for the >> sja. > > Ah, right.
Can you have a look at the timing constants for the rtcanl1 aswell as it's ref clock. (Patches 1 and 3). >> The original algorithm find optimal values for the sja (no bitrate error >> and no sample point error). My patch just optimizes the sample point in >> cases where you cannot avoid bitrate errors. > > Good. At some point we may want to update the algorithm in the kernel as > well. Sure this is why I made this whole patch series. >>> bitrate, especially with exotic clock frequencies. Those require manual >>> fiddling with the bit-timing parameters, e.g. SJW, which is non-trivial. >> I tend to call them "real live" clock values :) > > Yes, that's the real fun. This is why I added the mscan with several ref clocks: 32, 33, 33.3 and 33 1/3 MHz. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
