Hi Oliver.

> diff --git a/drivers/net/can/sja1000/sja1000.h 
> b/drivers/net/can/sja1000/sja1000.h
> index 97a622b..de8e778 100644
> --- a/drivers/net/can/sja1000/sja1000.h
> +++ b/drivers/net/can/sja1000/sja1000.h
> @@ -167,6 +167,7 @@ struct sja1000_priv {
>  
>       void __iomem *reg_base;  /* ioremap'ed address to registers */
>       unsigned long irq_flags; /* for request_irq() */
> +     spinlock_t cmdreg_lock;  /* lock for concurrent cmd register writes */
>  
>       u16 flags;              /* custom mode flags */
>       u8 ocr;                 /* output control register */

You define your spinlock inside a struct so you cannot use
DEFINE_SPINLOCK().

But then you need to use spin_lock_init() - which I fail to see
you are doing in your patch.

        Sam
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core

Reply via email to