On 06/18/2010 02:00 PM, Hans J. Koch wrote: > On Fri, Jun 18, 2010 at 11:47:04AM +0200, Wolfgang Grandegger wrote: >> Hi Hans-Jürgen, >> >> On 06/17/2010 12:52 PM, Hans J. Koch wrote: >>> This adds a driver for FlexCAN based CAN controllers, >>> e.g. found in Freescale i.MX35 SoCs. >>> >>> The original version of this driver was posted by Sascha Hauer in July 2009: >>> http://kerneltrap.org/mailarchive/linux-netdev/2009/7/29/6251621 >>> >>> I took this version, added NAPI support, and fixed some problems found >>> during testing. Well, here is the result. Please review. >> >> I briefly browsed the patch and various bits and pieces are missing or >> not correctly implemented. Marc already pointed out a few of them: > > Before we continue, we should address the fact that we now have two versions > of the driver. It doesn't make sense to work on both. > Just for the record, I knew that Marc was working on this, and offered > cooperation in a private mail a few weeks ago. He never answered, so I made > it work myself, and posted it as soon as I could. A few hours after he saw > that, he came up with his version... > > So, instead of continuing wasting engineering powers, you should decide > which of the two versions is in the better shape already, and we continue > working on that. I don't mind at all if you choose Marc's version. I'm > not running after copyright lines, I just want to see flexcan in mainline > as soon as possible.
Me too. Marc's version is definitely more up-to-date and should be taken as starting point. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
