Hi Qi-san > OKI-sans, would you please take a look at ./include/linux/kfifo.h, and try to > use this structure and APIs?
Thank you for your answer. We will start doing the above next week. Thanks, Ohtake ----- Original Message ----- From: "Wang, Qi" <[email protected]> To: "Daniel Baluta" <[email protected]>; "Masayuki Ohtak" <[email protected]> Cc: <[email protected]>; "Wolfgang Grandegger" <[email protected]>; <[email protected]>; <[email protected]>; "Khor, Andrew Chih Howe" <[email protected]>; <[email protected]>; <[email protected]>; "Wang, Yong Y" <[email protected]> Sent: Thursday, August 12, 2010 10:42 AM Subject: RE: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35 > > -----Original Message----- > > From: Daniel Baluta [mailto:[email protected]] > > Sent: Wednesday, August 11, 2010 6:37 PM > > To: Masayuki Ohtak > > Cc: [email protected]; Wolfgang Grandegger; > > [email protected]; [email protected]; Khor, Andrew Chih > > Howe; [email protected]; [email protected]; Wang, Qi; Wang, Yong Y > > Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35 > > > > Hi, > > > > 2010/8/11 Masayuki Ohtak <[email protected]>: > > > CAN driver of Topcliff PCH > > > > > > Topcliff PCH is the platform controller hub that is going to be used in > > > Intel's upcoming general embedded platform. All IO peripherals in > > > Topcliff PCH are actually devices sitting on AMBA bus. > > > Topcliff PCH has CAN I/F. This driver enables CAN function. > > > > > > Signed-off-by: Masayuki Ohtake <[email protected]> > > > > I have a few questions: > > > > 1. Is your code based on Intel's CAN EP80579 ([1]) ? > No. > > 2. Why don't you use kernel existing kfifo infrastructure? ([2]). > Just take a look at kfifo.h. This structure has been changed. I remembered > there was a spin_lock from kfifo previously. Currently it's been removed, good. > OKI-sans, would you please take a look at ./include/linux/kfifo.h, and try to > use this structure and APIs? > > Daniel, > > We're anxious to integrate those codes now. Perhaps it'll take us quite a > long time to use kfifo. How about implementing it with the next version? > > Best Regards, > Qi. > > > 3. Can you provide a pointer to Topcliff PCH CAN I/F datasheet ? > Currently this datasheet isn't open. > > > > thanks, > > Daniel. > > > > [1] http://www.intel.com/design/intarch/ep80579/sw_tools.htm > > [2] http://lxr.linux.no/#linux+v2.6.35/kernel/kfifo.c > _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
