Hi Wolfgang, Thank you for your comment. We don't use kfifo infrastructure but brush up with current framework.
Thanks, Ohtake(OKISEMI) ----- Original Message ----- From: "Wolfgang Grandegger" <[email protected]> To: "Masayuki Ohtake" <[email protected]> Cc: "Wang, Qi" <[email protected]>; <[email protected]>; <[email protected]>; "Wang, Yong Y" <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; "Khor, Andrew Chih Howe" <[email protected]>; "Morinaga" <[email protected]> Sent: Friday, August 20, 2010 4:59 PM Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35 > Hi Ohtake, > > On 08/20/2010 08:01 AM, Masayuki Ohtake wrote: > > Hi Wolfgang, > > > >>>>>> 2. Why don't you use kernel existing kfifo infrastructure? ([2]). > >>>>> Just take a look at kfifo.h. This structure has been changed. I > >>>>> remembered > >>>> there was a spin_lock from kfifo previously. Currently it's been > >>>> removed, good. > >>>>> OKI-sans, would you please take a look at ./include/linux/kfifo.h, and > >>>>> try to > >>>> use this structure and APIs? > >>>> > >>>> As I see it, the code related to that fifo is not used (== dead code)? > >>> I'm not familiar with kfifo structure, and I didn't like it because there > >>> need a spin_lock to use it. > > > > We are about to study kfifo infra structure. > > I have a question. > > > > It seems all CAN drivers accepted by upstream don't use kfifo > > infrastructure, right ? > > Right! > > > (I couldn't see message with "grep kfifo * in drivers/net/can") > > > > If yes, why should we use the kfifo ? > > If no, please show me the kfifo reference driver > > Sorry, nobody (of the socketcan core developers) said that kfifo should > be used. We believe, that an additional queuing of CAN messages is *not* > needed at all. Just eliminate the related code and follow more closely > the existing mainline drivers. > > Wolfgang. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
