Hi Matthias, > good work.
Thanks. Your support has been critical in testing earlier versions of this driver. > On Thursday 26 August 2010 06:41, Bhupesh SHARMA wrote: > > SPEAr320 design contains two boards: > > a) CPU board (which houses the ARM926ejs CPU and DDR in addition to > some other interfaces like USB host etc..) > > b) Application PLC board (which contains two Bosch CCAN IPs that are > interfaced to APB bus in addition to other interfaces like UART etc..) > > [See details here: > http://www.st.com/stonline/products/families/embedded_mpu/spear_mpus/sp > ear320_single_core.htm] > Is this relevant for this driver? > > > > The SPEAr CAN driver relies on 'platform data/board specific details' > that are passed by means of relevant evb files present in > 'arch/arm/mach-spear3xx' directory. > > > > Signed-off-by: Bhupesh Sharma <[email protected]> > > > > Index: spear320_can.c > > =================================================================== > ... > > + platform_driver_unregister(&spear320_can_driver); > > +} > > +module_exit(spear320_can_cleanup); > > + > > +MODULE_AUTHOR("Bhupesh Sharma <[email protected]>"); > > +MODULE_LICENSE("GPL"); > > +MODULE_DESCRIPTION("CAN bus driver for SPEAr320 which has 2 CCAN > controllers"); > What about > MODULE_DESCRIPTION("CAN bus driver for SPEAr320"); > > The driver does not care about the number of available cores. This is > handled by the platform configuration. > So no need to mention it here. The MODULE_DESCRIPTION that you have suggested also seems good. Infact, initially we had decided to keep the same but then we came across further variants of the SPEAr microcontroller in which the number of CCAN Controllers may vary. For example SPEAr1310 is a CORTEX-A9 based microcontroller that also has 2 CCAN controllers. So, we decided to make this distinction clear in the MODULE_DESCRIPTION field. Regards, Bhupesh _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
