On 10/15/2010 02:25 PM, Marc Kleine-Budde wrote: >>>> And here is a driver for the Microchip MCP2515 SPI controller: >> >> Can I have your S-o-b for the patch? >> I want to test it and fix problems from my review. > > I've applied the patch to net-next-2.6: > > http://git.pengutronix.de/?p=mkl/linux-2.6.git;a=shortlog;h=refs/heads/can/mcp251x-async
In this branch I've addressed some of the remarks from my review. Due
to missing CAN cable I cannot test the driver....
Andre, have a look at my branch before you start hacking. Here the
short log, I don't want so spam the ML with not really tested patches.
Marc Kleine-Budde (11):
can: mcp2515: use dev as variable name for net_device
can: mcp2515: minor coding style improvements
can: mcp2515: use struct mcp251x_platform_data
can: mcp2515: use can_dropped_invalid_skb in xmit
can: mcp2515: don't drop frames with dlc > 8
can: mcp2515: remove dev->trans_start
can: mcp2515: use SET_NETDEV_DEV
can: mcp2515: use dev_* functions instead of printk
can: mcp2515: print CNF register contents
can: mcp2515: use u8 instead of unsinged char for hw registers
can: mcp2515: use C99 initializer and sizeof instead hardcoding buffer
lengths
cheers, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
