On 10/25/2010 12:15 AM, Marc Kleine-Budde wrote: > On 10/25/2010 12:09 AM, David Miller wrote: >> From: Marc Kleine-Budde <[email protected]> >> Date: Mon, 25 Oct 2010 00:05:25 +0200 >> >>> On 10/24/2010 11:43 PM, David Miller wrote: >>>> From: Masayuki Ohtak <[email protected]> >>>> Date: Fri, 15 Oct 2010 22:00:28 +0900 >>>> >>>>> CAN driver of Topcliff PCH >>>>> >>>>> Topcliff PCH is the platform controller hub that is going to be used in >>>>> Intel's upcoming general embedded platform. All IO peripherals in >>>>> Topcliff PCH are actually devices sitting on AMBA bus. >>>>> Topcliff PCH has CAN I/F. This driver enables CAN function. >>>>> >>>>> Signed-off-by: Masayuki Ohtake <[email protected]> >>>> >>>> Applied, thanks. >>> >>> IMHO this driver needs some improvements. There are some open points >>> from Wolfgangs and my review. On the other side, it's a new driver and >>> there's some time left before it hits mainline. >> >> When people have more than a week to review and provide feedback, >> and don't, I have zero sympathy especially this early in the >> release cycle. > > Let me see....Crap, it's my fault, I just replied to the socketcan > mailinglist ;( [1] > >> So if adding it to the tree is what I have to do to get you guys to >> post your comments and suggest fixes, then that's what I am going to >> (continue) to do. :-) > > ...or to learn how to reply properly :)
Ah, oh, and I added my review to yours :-(. Sorry, for the inconvenience it caused: https://lists.berlios.de/pipermail/socketcan-core/2010-October/004787.html Anyway, Ohtake should have received the review. The driver is *not* yet ready for inclusion. Therefore, please fix the remaining issues asap. Thanks, Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
