Hi David Miller, I see, I just have to obey your saying. I will split our patch per issue/indicated item and re-submit to you.
Thanks, Tomoya MORINAGA OKI SEMICONDUCTOR CO., LTD. ----- Original Message ----- From: "David Miller" <[email protected]> To: <[email protected]> Cc: <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]> Sent: Wednesday, November 17, 2010 6:10 AM Subject: Re: [PATCH net-next-2.6 v4] can: Topcliff: PCH_CAN driver: Add Flow control/Fix Endianess issue/Separate IF register/Enumerate LEC macro/Move MSI processing/Use BIT(X)/Change Message Object index/Add prefix PCH_ > From: Wolfram Sang <[email protected]> > Date: Tue, 16 Nov 2010 22:07:16 +0100 > > > On Tue, Nov 16, 2010 at 12:43:25PM -0800, David Miller wrote: > >> From: Wolfgang Grandegger <[email protected]> > >> Date: Tue, 16 Nov 2010 21:39:47 +0100 > >> > >> > Please take into account that this patch got accepted by accident > >> > (because the maintainer did not respond properly in time). At that time > >> > the driver was incomplete, not ready for mainline and did not even work > >> > properly. Therefore it makes little sense to debug or even bisec these > >> > changes. Just for that reason I made an exemption and added my > >> > "Acked-by". Hope you can share my arguments. > >> > >> You don't put stupid on top of stupid and justify the latter using > >> the former. > > > > Is reverting the incomplete driver an option? > > I told everyone that the plan was that we had several months > to fix this, and that's what we should do. > > But yes if people are going to be maximally difficult about this and > refuse to split up the bug fixes, I will have to regrettably revert > the driver. > > But let's avoid that if we can. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
