From: Bhupesh SHARMA <[email protected]> Date: Mon, 14 Feb 2011 13:30:45 +0800
> I realized the problem happens when one compiles c_can files for x86 platform. > As I have a ARM based platform, I get the "clk_get_rate", "clk_get" and > "clk_put" definitions correctly when I perform the build operations. > > Now there can be two approaches to solve this issue: > 1. Restrict C_CAN build only for ARM based platforms by adding the > dependency "depends on HAVE_CLK" in the Kconfig file for C_CAN. > For e.g. see the I2C_DESIGNWARE case: > http://lxr.linux.no/linux+v2.6.31/drivers/i2c/busses/Kconfig#L329 > > 2. Add #if defined(CONFIG_HAVE_CLK) macros to protect this code in > "c_can_platform.c" > For e.g. see: http://lxr.linux.no/linux+v2.6.31/drivers/serial/sh-sci.c#L1085 > > IMHO, approach 2 seems better as it will allow C_CAN to work on x86 platforms > as well which will suit Intel TopCliff platform also. > > Please let me know your views on the same and I will send a v8 accordingly. #2 is definitely better. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
