Hi,
On 02/23/2011 02:35 PM, Andrej Krutak wrote:
> Hi,
>
> just wanted to inform you - in the mpc512x_can_get_clock() function
> (drivers/net/can/mscan/mpc5xxx_can.c), there are calls to clg_get(), and
> later
> checks
>
> if (!sys_clk) {
> and
> if (!ref_clk) {
>
> but these should be
>
> if (IS_ERR(sys_clk)) {
> and
> if (IS_ERR(ref_clk)) {
>
> (otherwise you'll get an oops if something goes wrong with clg_get()).
Thanks for the info. I'm going to prepare a patch.
Wolfgang.
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
