On Tue, Apr 05, 2011 at 07:08:41PM +0200, Enric Balletbo i Serra wrote: > ret = request_threaded_irq(spi->irq, NULL, mcp251x_can_ist, > - IRQF_TRIGGER_FALLING, DEVICE_NAME, priv); > + pdata->irq_flags ? pdata->irq_flags : IRQF_TRIGGER_FALLING, > + DEVICE_NAME, priv);
IMHO, doing like this looks just a tiny bit cleaner > + pdata->irq_flags ?: IRQF_TRIGGER_FALLING, > + DEVICE_NAME, priv); That's really the only remark :-) Regards, Kurt _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
