On 04/28/2011 09:26 AM, Kurt Van Dijck wrote: > On Wed, Apr 27, 2011 at 04:19:52PM +0200, Marc Kleine-Budde wrote: >> On 04/27/2011 11:06 AM, Kurt Van Dijck wrote: >>> This patch adds SAE J1939 tools & libraries to can-utils >>> >>> * jacd: a J1939 address claiming daemon >>> * jspy: spy on a J1939 bus >>> * jsr: send/receive J1939 packets >>> >>> * libj1939.a: conversion to/from struct sockaddr_can to string >>> >>> Signed-off-by: Kurt Van Dijck <[email protected]> >> >> Can you please add you programs to Makefile.am, too? > > Since I'm not an autotools expert, can someone confirm I did not produce > crap here. It builds for me at least.
\o/ - If it compiles, let's ship it!
>
> Kurt
>
> ---
> Index: can-utils/configure.ac
> ===================================================================
> --- can-utils/configure.ac (revision 1240)
> +++ can-utils/configure.ac (working copy)
> @@ -108,6 +108,7 @@
> AC_CHECK_HEADERS([ \
> linux/can/gw.h \
> linux/can/isotp.h \
> + linux/can/j1939.h \
> ],[],[],
> [
> #ifdef HAVE_SYS_SOCKET_H
> @@ -117,6 +118,7 @@
>
> AM_CONDITIONAL(CONFIG_GW, [test "${ac_cv_header_linux_can_gw_h}" = "yes"])
> AM_CONDITIONAL(CONFIG_ISOTP, [test "${ac_cv_header_linux_can_isotp_h}" =
> "yes"])
> +AM_CONDITIONAL(CONFIG_J1939, [test "${ac_cv_header_linux_can_j1939_h}" =
> "yes"])
>
>
> AC_CHECK_DECL(SO_RXQ_OVFL,,
> Index: can-utils/GNUmakefile.am
> ===================================================================
> --- can-utils/GNUmakefile.am (revision 1240)
> +++ can-utils/GNUmakefile.am (working copy)
> @@ -52,6 +52,18 @@
> isotptun
> endif
>
> +if CONFIG_J1939
> +bin_PROGRAMS += \
> + jacd \
> + jsr \
> + jspy
> +
> +LDADD += libj1939.la
It would be cleaner if you just link your j1939 programs with the lib:
jacd_LDADD = libj1939.la
jsr_LDADD = libj1939.la
jspy_LDADD = libj1939.la
(I know we link everything against libcan.la)
> +noinst_LTLIBRARIES += libj1939.la
> +
> +libj1939_la_SOURCES = libj1939.c
> +endif
> +
> EXTRA_DIST = \
> autogen.sh
>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
