Oliver,

I'm on an isobus (=modified j1939) event now.
Some fixes turned up already:

Index: net/can/j1939/rtnl.c
===================================================================
--- net/can/j1939/rtnl.c        (revision 1255)
+++ net/can/j1939/rtnl.c        (working copy)
@@ -204,7 +204,7 @@
                read_lock_bh(&jseg->lock);
                for (addr = cb->args[2]; addr < J1939_IDLE_ADDR; ++addr) {
                        ent = &jseg->ents[addr];
-                       if (!ent->flags)
+                       if (!(ent->flags & ECUFLAG_LOCAL))
                                continue;
                        ret = j1939rtnl_fill_ifaddr(skb, netdev->ifindex, addr,
                                        0, ent->flags, NETLINK_CB(cb->skb).pid,
Index: net/can/j1939/address-claim.c
===================================================================
--- net/can/j1939/address-claim.c       (revision 1255)
+++ net/can/j1939/address-claim.c       (working copy)
@@ -173,7 +173,7 @@
                         * schedule a timer soon now
                         */
                        hrtimer_try_to_cancel(&dut->ac_timer);
-               if (dut->name > ecu->name)
+               if ((ecu->sa == dut->sa) && (dut->name > ecu->name))
                        dut->sa = J1939_IDLE_ADDR;
        }
 
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core

Reply via email to