On 05/12/2011 02:54 PM, Arnd Bergmann wrote: > On Thursday 12 May 2011, Wolfgang Grandegger wrote: >> Well, that seems sophisticated resulting in a complex implementation >> (may code line) also because hardware filters are very hardware >> dependent. Usually just one global filter can be defined. I think that's >> overkill. A simple interface using: >> >> ip link set can0 type can filter <id>:<mask> [<id>:<mask> ...] >> >> would just be fine. > > Ok, fair enough. Still I would suggest you first come up with > a reasonable user interface (the one you posted may be just right, > I don't know), and then let someone do the implementation in the > pruss firmware that is the best match for the user interface, rather > than the other way around.
I suggested some time ago to implement the more-or-less standard <id>:<mask> filter instead of just a single <id> (per filter entry). The cost is probably quite low, it's just a single AND operation per filter entry more expensive. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
