On 09/23/11 11:10, Markus Plessing wrote: > Hi Oliver, > > looks quite good for me - more comments inline.
Thanks for the review. Based on your comments to patch v3 i was changing these things: --- ems_pcmcia.c-orig 2011-09-23 18:17:51.683718927 +0200 +++ ems_pcmcia.c 2011-09-23 18:13:59.227726972 +0200 @@ -1,3 +1,3 @@ /* - * Copyright (C) 2008 Sebastian Haas <[email protected]> + * Copyright (C) 2008 Sebastian Haas (initial chardev implementation) * Copyright (C) 2010 Markus Plessing <[email protected]> @@ -29,3 +29,3 @@ -MODULE_AUTHOR("Sebastian Haas <[email protected]>"); +MODULE_AUTHOR("Markus Plessing <[email protected]>"); MODULE_DESCRIPTION("Socket-CAN driver for EMS CPC-CARD cards"); @@ -104,3 +104,3 @@ /* Check interrupt for each channel */ - for (i = 0; i < EMS_PCMCIA_MAX_CHAN; i++) { + for (i = 0; i < card->channels; i++) { dev = card->net_dev[i]; @@ -144,5 +144,2 @@ - if (!card) - return; - free_irq(pdev->irq, card); I'll send the final patch to netdev-ML for net-next soon. Best regards, Oliver _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
