Hi Christian,

I realize some minor issues in Erik's output, which needs to be fixed
for kernel inclusion.

Erik Calissendorff wrote:
[snip]
 r...@overo:~# cansend can0 000#
>   can0  20000004  [8] 00 20 00 00 00 00 00 00   ERRORFRAME
>   caNOHZ: local_softirq_pending 08
> n0  20000040  [8] 00 00 00 00 00 00 00 00   ERRORFRAME
> r...@ovenohz: local_softirq_pending 08
> ro:~#   can0  20000040  [8] 00 00 00 00 00 00 00 00   ERRORFRAME
>   can0  20000040  [8] 00 00 00 00 00 00 00 00   ERRORFRAME
>   can0  20000040  [8] 00 00 00 00 00 00 00 00   ERRORFRAME
>   can0  20000004  [8] 00 20 00 00 00 00 00 00   ERRORFRAME
>   can0  20000040  [8] 00 00 00 00 00 00 00 00   ERRORFRAME
>   can0  20000040  [8] 00 00 00 00 00 00 00 00   ERRORFRAME
>   can0  20000040  [8] 00 00 00 00 00 00 00 00   ERRORFRAME
>   can0  20000040  [8] 00 00 00 00 00 00 00 00   ERRORFRAME
>   can0  20000040  [8] 00 00 00 00 00 00 00 00   ERRORFRAME
>   can0  20000004  [8] 00 20 00 00 00 00 00 00   ERRORFRAME
>   can0  20000040  [8] 00 00 00 00 00 00 00 00   ERRORFRAME
>   can0  20000004  [8] 00 20 00 00 00 00 00 00   ERRORFRAME

We clarified the bus-off handling recently for devices doing bus-off
recovery automatically. If "restart-ms==0", the device shall be stopped
on bus-off and can_bus_off() called subsequently. Otherwise the hardware
is allowed to recover from bus-off automatically. If that happens, the
"RESTARTED" error message shall be sent and the "can_stats.restarts"
variable shall be incremented. Have a look to the at91_can driver for
further details.

> r...@overo:~# ip -d -s link show can0
> 2: can0: <NOARP,UP,LOWER_UP,ECHO> mtu 16 qdisc pfifo_fast state UP qlen 10
>     link/can
>     can state ERROR-ACTIVE restart-ms 0
>     bitrate 250000 sample-point 0.850
>     tq 200 prop-seg 8 phase-seg1 8 phase-seg2 3 sjw 1
>     : tseg1 3..16 tseg2 2..8 sjw 1..4 brp 1..64 brp-inc 1

The CAN controller does not have a name:

static struct can_bittiming_const mcp251x_bittiming_const = {
        .name = DEVICE_NAME; /* is missing !!! */
        .tseg1_min = 3,
        .tseg1_max = 16,
        .tseg2_min = 2,
        .tseg2_max = 8,
        .sjw_max = 4,
        .brp_min = 1,
        .brp_max = 64,
        .brp_inc = 1,
};

Wolfgang.
_______________________________________________
Socketcan-users mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-users

Reply via email to