Hi Wolfgang, On Tue, Nov 03, 2009 at 07:54:21PM +0100, Wolfgang Grandegger wrote: > Wolfgang Grandegger wrote: > > Hi Fu, > > > > Luotao Fu wrote: > >> Hi, > >> in following the new patch as discussed yesterday. I add a XXX marked > >> comment to this. Works all right on my setup. Please review. > > > > I will try it on my setup later today or tomorrow. > > I just started to do some tests, sorry for the delay. When I stop the > device without any traffic, I get the message: > > # ./ip link set can2 up type can bitrate 125000 > # ifconfig can2 down
should the ifconfig down not come before setting the bitrate? > mpc52xx_can f0000980.can: SLPRQ timeout reached, failed to enter sleep mode! > > I have a MPC5200 v1.2. I assume that you do not see that behavior on > your test board!? > Yes I do. You just ran into the ominous hardware bug we discussed and the patch is for. I replaced the error return value with a warning here. This is exactly the fix we need so that the device won't get frozen. cheers Luotao Fu -- Pengutronix e.K. | Dipl.-Ing. Luotao Fu | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
signature.asc
Description: Digital signature
_______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
