On 25.09.2010 23:20, Daniele Venzano wrote:

Hello Daniele,

> since I wanted to use BCM sockets for a couple of application we are
> developing at my company, I had to find out how they actually work.

Thanks for picking this up - indeed i had that on my todo list much too long.

> I found the German LaTeX documents inside the SVN repository and I
> translated them in English. I put the files on a website and I can keep
> them there forever, but I think they could also be put with their older
> german brothers in the source repository.

Unforunately *many* things (like struct sockaddr_can) was outdated in the TeX
documentation. Also the introduction and the legal stuff and the
procfs-entries (like /proc/net/can/version or the sja1000 driver stuff) has
been changed or removed entirely. LLCF could be renamed to SocketCAN, etc.

In general i would suggest to add the API documentation to

    linux/Documentation/networking/can.txt

but i was unsure if the BCM stuff better would go into

    linux/Documentation/networking/can-bcm.txt

to prevent can.txt being growing too much.

Finally i would tend to add the translated BCM documentation, the timestamp
stuff and probably some more procfs details in
Documentation/networking/can.txt which is the up-to-date documentation. E.g.
chapter 4.2

http://lxr.linux.no/#linux+v2.6.35.5/Documentation/networking/can.txt#L474

has been already reserved for the BCM.

I would suggest to work on the SVN

   socketcan/trunk/kernel/2.6/Documentation/networking/can.txt

until the documentation is fine to be added to mainline Linux.

Currently there's only a tiny difference, someone fixed in Mainline :-))

--- socketcan/trunk/kernel/2.6/Documentation/networking/can.txt
+++ net-next-2.6/Documentation/networking/can.txt
@@ -334,7 +334,7 @@
             return 1;
     }

-    /* paraniod check ... */
+    /* paranoid check ... */
     if (nbytes < sizeof(struct can_frame)) {
             fprintf(stderr, "read: incomplete CAN frame\n");
             return 1;


Would this approach be ok for you?

Tnx & best regards,
Oliver
_______________________________________________
Socketcan-users mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-users

Reply via email to