This patch remove the setting of the FLEXCAN_MCR_SRX_DIS. This bit
disables the self reception of transmitted can frames. Which breaks
IFF_ECHO.

Signed-off-by: Marc Kleine-Budde <[email protected]>
Cc: Bhaskar Upadhaya <[email protected]>
Cc: Scott Wood <[email protected]>
---
Hello Bhaskar and Scott,

can you please add this patch to your powerpc linux-2.6.35 kernel, as your
driver breaks the IFF_ECHO feature.

Are you interested in collaborating to mainline the device tree support
for the flexcan driver?

cheers, Marc

 drivers/net/can/flexcan.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 5b1a967..0c5adae 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -542,8 +542,7 @@ static int flexcan_chip_start(struct net_device *dev)
         */
        reg_mcr = flexcan_cb->read(&regs->mcr);
        reg_mcr |= FLEXCAN_MCR_FRZ | FLEXCAN_MCR_FEN | FLEXCAN_MCR_HALT |
-               FLEXCAN_MCR_SUPV | FLEXCAN_MCR_WRN_EN | FLEXCAN_MCR_IDAM_C |
-               FLEXCAN_MCR_SRX_DIS;
+               FLEXCAN_MCR_SUPV | FLEXCAN_MCR_WRN_EN | FLEXCAN_MCR_IDAM_C;
        dev_dbg(dev->dev.parent, "%s: writing mcr=0x%08x", __func__, reg_mcr);
        flexcan_cb->write(reg_mcr, &regs->mcr);
 
-- 
1.7.4.1

_______________________________________________
Socketcan-users mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-users

Reply via email to