On 08/04/2011 02:22 PM, Robin Holt wrote: > On Thu, Aug 04, 2011 at 01:49:51PM +0200, Marc Kleine-Budde wrote: >> On 08/04/2011 01:43 PM, Robin Holt wrote: >>>> Have you already posted them? >>>> >>>> From my point of view there are two problems: >>>> - OF tree integration (iomem, irq, clock) >>>> - endianess >>>> >>>> The fsl driver assumes that OF tree means a big endian hardware, this is >>>> not true for arm, where we have OF tree now. >>> >>> I implemented the endianess bits with a couple static inlines called >>> flexcan_read/flexcan_write. >> >> I'm going to test your patches on arm if you post them. > > Is there an arm in_be32 which is equivalent to readl? Ditto out_be32 > == writel? If so, can we just convert all readl/writel's in flexcan.c > over to in_be32 and out_be32?
"be32" is wrong for the arm i.mx in little endian mode. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
