On Thu, Aug 04, 2011 at 06:35:06PM +0200, Wolfgang Grandegger wrote: > Hi Robin, > > On 08/04/2011 06:23 PM, Robin Holt wrote: > > Add a wrapper function for a register dump when CONFIG_CAN_DEBUG_DEVICES > > is set. > > > > Signed-off-by: Robin Holt <[email protected]> > > To: Marc Kleine-Budde <[email protected]> > > Cc: [email protected] > > This patch is useful for development but should be dropped for mainline.
I am not sure why? There is already a CONFIG_CAN_DEBUG_DEVICES Kconfig setting. This just makes it of use for flexcan.c. The code is not made less readable by the patch and when CONFIG_CAN_DEBUG_DEVICES=n, there is no code difference with and without the patch. It seems like we would minimize bit rot if it were maintained in the mainline tree. What are the arguments against having it included? Robin _______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
