On 08/04/2011 09:15 PM, Robin Holt wrote:
> It looks like the of_device stuff got moved under the
> platform_device->driver and all we should need to do is define an
> of_match to get a .probe call out.  Give this a try.

have you tested the driver on PPC? what about the clock stuff, does it
work properly?

> 
> Signed-off-by: Robin Holt <[email protected]>
> To: Marc Kleine-Budde <[email protected]>
> To: Wolfgang Grandegger <[email protected]>
> Cc: [email protected]
> ---
>  drivers/net/can/flexcan.c |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index 74b1706..75e4d9c 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -1033,8 +1033,18 @@ static int __devexit flexcan_remove(struct 
> platform_device *pdev)
>       return 0;
>  }
>  
> +static struct of_device_id flexcan_of_match[] = {
> +     {
> +             .compatible = "fsl,flexcan-v1.0",
> +     },
> +};

I think you have to NULL-terminate that list.

> +
>  static struct platform_driver flexcan_driver = {
> -     .driver.name = DRV_NAME,
> +     .driver = {
> +             .name = DRV_NAME,
> +             .owner = THIS_MODULE,
> +             .of_match_table = flexcan_of_match,
> +     },
>       .probe = flexcan_probe,
>       .remove = __devexit_p(flexcan_remove),
>  };

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Socketcan-users mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-users

Reply via email to