On 08/24/2011 12:56 PM, Ansell, John wrote:
> Major progress! I can get messages through can0 now, I'll look at can1
> later. But I'm not sure I understand the fix!
> 
> The problem as I see it is that the mcp251x driver requests a falling
> edge triggered interrupt but function gpio_irq_type() (in gpio.c)
> doesn't allow that for some reason.
> 
> The (temporary?) fix is to make gpio_irq_type() accept
> IRQ_TYPE_EDGE_FALLING as well, but I suspect that will blow other stuff
> out of the water.

Puh, heavy hack ;-).

> What would be the best way to fix this properly?

The platform code should provide a proper "pdata->irq_flags" setting:

  http://lxr.linux.no/#linux+v3.0.3/drivers/net/can/mcp251x.c#L933

Wolfgang.

_______________________________________________
Socketcan-users mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-users

Reply via email to