On 11/29/2011 11:51 AM, Marc Kleine-Budde wrote: > On 11/29/2011 11:47 AM, Marc Kleine-Budde wrote: >> On 11/29/2011 10:11 AM, Wolfgang Grandegger wrote: >>> Already since a while we have support for the Bosch CC770 and Intel >>> AN82527 CAN controllers in our out-of-tree Socket-CAN repository. >>> >>> In the meantime I found a TQM855L board with two AN82527 on it, >>> which allowed me to provide and test a generic platform driver >>> as well. >>> >>> Changes since v1: >>> >>> - remove version.h includes >>> - some minor corrections in the ISA bus driver >>> - add platform header file to the driver core >>> - add generic platform driver >>> - add and update device tree nodes for tqm8xx and tqm8548 >>> >>> Changes since v2: >>> >>> - correct license text as suggest by Oliver Hartkopp >>> - use the new module_platform_driver function >>> - provide get_berr_counter callback for cc770 >>> - improve CAN error state change handling >>> - more comprehensive cc770_isa driver description >>> >>> Changes since v3: >>> >>> - pre-define pr_fmt() >>> - use KBUILD_MODNAME instead of DRV_NAME >>> - use ARRAY_SIZE() whenever appropriate >>> - use variable name "o" for message objects consistantly >>> - use proper error code for cc770_probe_chip >>> - remove unneeded member priv->open_time >>> - remove unnecessary masking of u8 variables (with 0xff) >>> - use "!skb" instead of "skb == NULL" >>> - CC770_MSG_MAX now limits the number of messages read in the ISR >>> - use "|" instead of "+" to combine bit masks >>> - remove return code check of platform_get_resource() in remove function >>> - remove postal address from GPL copyright text >>> - fix WARNING: __packed is preferred over __attribute__((packed)) >>> - some more minor fixes (casts, white space, etc.) >> >> Feel free to add by Acked-by to patches 1 and 2. > ^^ > my
Will do for the next version. You may also want to ack them explicitly. Thanks, Wolfgang. _______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
