So far, the bus error (berr) interrupt source is always enabled, even if bus error reporting is not requested (via ctrlmode flag CAN_CTRLMODE_BERR_REPORTING). This is not necessay, at least on the Flexcan of the i.MX28 SOC and it avoids flooding with with bus error interrupts. State changes interrupts do still arrive as documented. The function flexcan_has_and_handle_berr() has been removed and error state changes and bus errors are now packed into one error message by a common poll function, like for other CAN controllers.
CC: Reuben Dowle <[email protected]> Signed-off-by: Wolfgang Grandegger <[email protected]> --- drivers/net/can/flexcan.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index 0ce914a..095b74b 100644 --- a/drivers/net/can/flexcan.c +++ b/drivers/net/can/flexcan.c @@ -705,7 +705,10 @@ static int flexcan_chip_start(struct net_device *dev) reg_ctrl = flexcan_read(®s->ctrl); reg_ctrl &= ~FLEXCAN_CTRL_TSYN; reg_ctrl |= FLEXCAN_CTRL_BOFF_REC | FLEXCAN_CTRL_LBUF | - FLEXCAN_CTRL_ERR_STATE | FLEXCAN_CTRL_ERR_MSK; + FLEXCAN_CTRL_ERR_STATE; + + if (priv->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING) + reg_ctrl |= FLEXCAN_CTRL_ERR_MSK; /* save for later use */ priv->reg_ctrl_default = reg_ctrl; -- 1.7.4.1 _______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
