Dear Pekka,all
I noticed a strange behavior while receiving a "sendrecv" media offer
when user descriptor is set to "recvonly". The expected result should be
"recvonly", while sofia-sip set "sendrecv" (omits it).
In my opinion the code at soa_static.c line 1047 should be modified as below.
What do you think ?
Thanks in advance
Filippo Della Betta
Old code
send_mode = (sdp_mode_t)(um->m_mode & sdp_sendonly);
if (rm)
send_mode = (rm->m_mode & sdp_recvonly) ? sdp_sendonly : 0;
recv_mode = (sdp_mode_t)(um->m_mode & sdp_recvonly);
if (rm && rm->m_mode == sdp_inactive) {
send_mode = recv_mode = (sdp_mode_t)0;
}
else if (inactive_all) {
send_mode = recv_mode = (sdp_mode_t)0;
}
New code
send_mode = (sdp_mode_t)(um->m_mode & sdp_sendonly);
if (rm)
send_mode = send_mode & ( (rm->m_mode & sdp_recvonly) ? sdp_sendonly :
sdp_inactive );
recv_mode = (sdp_mode_t)(um->m_mode & sdp_recvonly);
if (rm)
recv_mode = recv_mode & ( (rm->m_mode & sdp_sendonly) ? sdp_recvonly :
sdp_inactive );
if (inactive_all) {
send_mode = recv_mode = (sdp_mode_t)0;
}
Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone
indicate. La diffusione, copia o qualsiasi altra azione derivante dalla
conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate
ricevuto questo documento per errore siete cortesemente pregati di darne
immediata comunicazione al mittente e di provvedere alla sua distruzione,
Grazie.
This e-mail and any attachments is confidential and may contain privileged
information intended for the addressee(s) only. Dissemination, copying,
printing or use by anybody else is unauthorised. If you are not the intended
recipient, please delete this message and any attachments and advise the sender
by return e-mail, Thanks.
------------------------------------------------------------------------------
_______________________________________________
Sofia-sip-devel mailing list
Sofia-sip-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sofia-sip-devel
