On Thu, Jul 19, 2018 at 01:39:14AM +0000, Tristan Cacqueray wrote: > On July 16, 2018 2:01 pm, Paul Belanger wrote: > > On Sun, Jul 15, 2018 at 10:47:25PM +0000, Tristan Cacqueray wrote: > > > Could we suggest Zuul to also do the review the OpenStack way? > > > > > > https://docs.openstack.org/project-team-guide/review-the-openstack-way.html > > > > > Could you be more specific here, which parts do we need to review the > > openstack > > way. > > > All the parts? > > For +2, this change has 3 +2s since three months: > https://review.openstack.org/554082 > > Considering the limited review bandwidth with the current core team, why > not +3 when there is already a +2? > I would ask in IRC for a +A, since it does have 3 +2, however most of the time we just want more eyes on a patch or coordinate landing a change. > > For +1, this could be used for good changes but that still need some > work, e.g. https://review.openstack.org/535558 probably need a > discussion around managing executor ssh key from nodepool > > > For -1, they are often use for things that can be added in a follow-up. > https://review.openstack.org/577357 got a -1, even though it fixed a > critical bug. It only got merged after SpamapS hit the issue. > > > And finally -2, i got those on features requested by partners, e.g. > https://review.openstack.org/535546 > > I don't know what to do, I bring the feature requests at several > occasions. The fact that there are no roadmap nor release > schedule makes it very difficult to contribute new features. > I think it would be totally fair to post above to zuul-discuss, either asking for review or guidance. Personally, I didn't realize these were idle so long, which makes me think we in SF need to be over communicating more.
So far, I've found adding things into the weekly zuul status email that goes out on Monday seems to get move eyeballs on review by people too. We used to have weekly meeting IRC meetings for zuul, which was the place I raised issues needing reviews in the past, given we decided to move to ML, I believe asking for review there too is fair. - Paul _______________________________________________ Softwarefactory-dev mailing list [email protected] https://www.redhat.com/mailman/listinfo/softwarefactory-dev
