On Wed, Feb 13, 2019 at 10:05 Nicolas Hicher wrote: > Hello, > > On 2/13/19 4:17 AM, Fabien Boucher wrote: >> Hi, LGTM as well. Do you plan to create a role sfconfig for instance >> with role action like: install, setup, recover ? > > > Yes, I thinks is the best thing to do. > > Waiting for Tristan input to create the story. > > Have a nice day. > > Nico >
What you proposed looks good to me. Looking at sf-ci job definition, we have those playbooks: - playbooks/get-logs.yaml - playbooks/functional.yaml - playbooks/upgrade.yaml - playbooks/openshift-integration.yaml - https://softwarefactory-project.io/r/#/c/12395/17/playbooks/remote-gerrit.yaml With those variables: - sf_arch - sf_version It would be nice to capture the common patterns and figure out a convenient set of role that we can use to create more complex job. In a follow-up, we should also investigate an easier task/library/script to update sfconfig.yaml. The current strategy is to use inlined python script that yaml.load, update, yaml.dump; which is fine for the context of that story. But we could have a "sfconfig" role that takes the sfconfig schema as a variable and update the file automatically. That way, we would just use "sfconfig", instead of "install-sfconfig", update the sfconfig.yaml as part of the job playbook, then "run-sfconfig". Cheers, -Tristan >> >> On Tue, Feb 12, 2019 at 9:12 PM Matthieu Huin <[email protected] >> <mailto:[email protected]>> wrote: >> >> LGTM >> >> On Tue, Feb 12, 2019 at 8:09 PM Nicolas Hicher <[email protected] >> <mailto:[email protected]>> wrote: >> >> Hello, >> >> We have a lot of tasks on sf-ci/playbooks/tasks which need to be >> converted in roles to ensure we can use them in other >> playbooks we have >> to add in our ci (validate multi-tenants, multinode, ...). >> >> The plan will be to convert these tasks in roles, then replace >> include_tasks by include_roles [1] >> >> It the first step to the refactoring of sf-ci, but it should >> not be to >> complicated to do. >> >> What do you think, do we need to do more things for this story >> [2] ? >> >> Nico >> >> [1] >> >> https://docs.ansible.com/ansible/latest/modules/include_role_module.html >> >> [2] https://tree.taiga.io/project/morucci-software-factory/us/2069 >> >> _______________________________________________ >> Softwarefactory-dev mailing list >> [email protected] >> <mailto:[email protected]> >> https://www.redhat.com/mailman/listinfo/softwarefactory-dev >> >> _______________________________________________ >> Softwarefactory-dev mailing list >> [email protected] <mailto:[email protected]> >> https://www.redhat.com/mailman/listinfo/softwarefactory-dev >> > _______________________________________________ > Softwarefactory-dev mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/softwarefactory-dev
signature.asc
Description: PGP signature
_______________________________________________ Softwarefactory-dev mailing list [email protected] https://www.redhat.com/mailman/listinfo/softwarefactory-dev
