: > To make testing multiple configs feasible, i'm still hopping we can make : > it possible to specify the path to the solrconfig.xml in a constructor to : > the SolrCore ... but i realized last night that SolrConfig is a static : > singleton ... changing that is going to be an anoying patch. : : Yes, I'm not real happy with the statics... way back when this was a : two week prototype hack, everything went into SolrCore (well, : everything except the schema). Over time, I've migrated stuff out, : but it's still not clean.
yeah ... i think what might make sense as a starting point is to replace any uses of "SolrConfig.config" with "SolrConfig.getConfig()" .. which would be a singleton/factory method returning the (now private SolrConfig.config if it is already set. if it's not set, then it would call SolrConfig.loadConfig(String path) using the default "solrconf/solrconfig.xml" (or whatever the systemproperty override is). SolrConfig.loadConfig(String path) should be public, so other classes (specifically the TestHarness i'm writing) can call it whenever they want to change the config. using different configs in parallel won't be possible .. but hey: baby steps. -Hoss
