[ http://issues.apache.org/jira/browse/SOLR-24?page=comments#action_12419345 ]
Bill Au commented on SOLR-24: ----------------------------- I have come across a test case there the patch doesn't work. I am using the data in example/exampledocs/ipod_other.xml. After adding the two docs I queried solr using curl: curl -i "http://localhost:8983/solr/select/?q=ipod&highlight=name&indent=true"; I got the following highlighting data in the response: <lst name="highlighting"> <lst name="id=IW-02"> <arr name="name"> <str>i<em>iPod</em> & i<em>iPod</em> Mini USB 22.0 Cable</str> </arr> </lst> <lst name="id=F8V7067-APL-KIT"> <arr name="name"> <str>Belkin Mobile Power Cord for i<em>iPod</em> w/ Dock</str> </arr> </lst> </lst> In both cases, there is an extra i in front of <em>iPod</em>. My guess is there is something wrong with the TokenStream passed to the Highligher. I am taking a closing look at that now. > Add Highlighting to standard request handler > -------------------------------------------- > > Key: SOLR-24 > URL: http://issues.apache.org/jira/browse/SOLR-24 > Project: Solr > Type: New Feature > Components: search > Reporter: Mike Klaas > Attachments: highlight_patch_v1.diff > > This patch adds highlighting functionality to solr request handlers it also > refactors StandardRequestHandler to use the common functionality provided in > SolrPluginUtils. I'd have preferred to do two separate patches, but creating > two mutually-dependent patches on a repo without being able to commit a > revision was daunting. > ----------------------------------- > Refactoring StandardRequestHandler: > 1. Moved solr.util.CommonParams to its own class. Removed DisMax-specific > parameters, and placed in a subclass. > 2. StandardRequestHandler uses CommonParams to store config-time parameter > values (new feature) > 3. StandardRequestHandler uses SolrPluginUtils methods for duplicate > functionality > 4. Some of said SPU methods have grown a "params" parameter to enable them to > use default values. (Note: instead of passing this around, something like a > RequestHelper class which carries the SolrRequest and Param values would be > useful. This class could house the utility methods that require Request > parameters). > 5. SolrPluginUtils.getParam() only uses the default parameter if it is null, > not blank. > -------------------------------------- > Highlighting: > 1. Highlighting is controlled by three request parameters: > highlight: list of fields to highlight, or highlight the default field if > at all present > maxSnippets: maximum number of snippets to return for each field > highlightFormatterClass: 'solr.<classname>' or full package path of > highlight.Formatter subclass to use in highlighting. > 2. Default formatter is to use <em> tags. There are issues with this > approach, but are mitigated with the ability to specify a custom Formatter. > Definately should consider alternatives (a custom xml approach to denote > highlit regions will require some Highlighter package hackery). > 3. Document summaries are returned as a separate element under <response> > format is still up for discussion. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
