I have committed the modified implementation based on Hoss' feedback,
including the addition of the setting to the example schema.xml and
to the wiki documentation.
Let me know if anything needs to be touched up to polish this off.
Many thanks for the solid leadership and thorough attention to detail
folks!
I suspect internally that an addition of a placeholder class for all
settings for SolrQueryParser would be the next step when more
settings are added, rather than having a bunch of independent getters
on IndexSchema.
Erik
On Jul 21, 2006, at 5:01 AM, Chris Hostetter wrote:
: > my one suggestion would be that we should support schema.xml
: > declarations
: > for all of the "setable" properties of the Lucene QueryParser...
: >
: > <solrQueryParser defaultOperator="AND"
: > fuzzyMinSim="0.5"
: > fuzzyPrefixLength="2"
: > locale="???"
: > lowerCaseExpandTerms="true"
: > phraseSlop="5" />
: >
: > ...i'm not saying I expect Erik to put in all the code to deal
with
: > all of
: > those now (unless you really want to Erik), just that it would
be a
: > good
: > idea if the config syntax for the default OP left room for them as
: > children of a larger solrQueryParser config block.
:
: My biggest problem with going the extra mile for these types of
: changes is that I simply don't have the time to do these types of
: things right with unit tests, documentation, and so on. I'm
I hear that ... i just ment that instead of using the xpath
expression...
/schema/queryParserDefaultOperator
...you might want to go ahead and use something like...
/schema/solrQueryParser/defaultOperator
...and commit it. the other options can come later.
-Hoss
