Mike Klaas commented on SOLR-43:
One thing I believe that was lost in this patch is static (source-level) defaults for parameters. Presumably these would be defined using another level of defaul parameters which is a static member of CommonParams or somesuch?
I assume you mean the default for things like "start" or "fl" if no handler defaults are defined? That would be one way to handle it... but most defaults are null anyway I think. And it's not too bad just having some defaults hardcoded like params.getInt(CommonParams.START, 0); If we did this, one might want to merge the global defaults with the handler defaults to eliminate the additional level of lookup.
Also, should SolrParams.parseBool() perhaps do a case-insensitive test?
I'm not opposed... is it needed though? -Yonik
