On 9/21/06, Chris Hostetter <[EMAIL PROTECTED]> wrote:

: I'll try to update my patch to pull out a getFieldFacets method that
: encapsulates parameter parsing and the decision of what faceting
: strategy to call... that way soneone could add their own method and
: override getFieldFacets() to call it in certain cases.  I'm not sure
: it's really a realistic use-case though.

I see your point ... i guess i tend to think that fragile base class
issues can be reduced by clearly documented pre/post conditions but yor
probably right ... this code is new enough and will probably fluctuate
enough over time that trying to anticipate all the use cases in advance is
asking for trouble, so structuring it as a toolkit of utilities is a
better idea then as a base class.

It's checked in.  Feel free to change things... I'm not married to the
specific static/non-static/name of methods.  Better to get what I have
out there so others can edit it also (esp since it's still in flux...
we won't be breaking anything by changing it now).

-Yonik

Reply via email to