:     Attachment: solr-XSLTResponseWriter-20060922.tar.gz

I finally got a chance to look at this tonight, i like it, but the big
thing thta jumped out at me was the configuration...

Since this QueryResponseWriter has use of configuration options, now is
probably the time to add an init(NamedList) method to the interface that
get's called with a upon construction by SolrCore just like
SolrRequestHandler (using DOMUtils.nodesToNamedList) ... that will have
the added benefit of allowing response writers to have defaults that can
be overriden by the defaults of the request handler *or* by query time
params.

FYI: an alternate approach to caching the Templates object in the
TransformProvider would be to use the SolrCache framework -- the
LRUCache doesn't currently have a notion of timed "expiration" but we
could just re-check the file modification in a CacheRegenertor and
document that the xsl files are only checked on commit.  (which may be a
better meme in general now that i think about).


-Hoss

Reply via email to