[ http://issues.apache.org/jira/browse/SOLR-59?page=comments#action_12446684 ] Yonik Seeley commented on SOLR-59: ----------------------------------
Looking good Bertrand! I think it might make more sense to use the normal query parameter mechanism to control this (requestHandler defaults in solrconfig). That way we can reuse all of the parameter code we already have, we avoid adding another element to solrconfig.xml, and most of all, we can change the behavior per-request (very useful for debugging). Also, why the extra addInfo element in the responseHeader? I think I liked it better the way you had it before. Side note/question: should we make responseHeader consistent with the generic response format? <lst name="responseHeader"> <int name="status">0</int> <int name="QTime">10</int> That would be a separate issue of course... > Copy request parameters to Solr's response > ------------------------------------------ > > Key: SOLR-59 > URL: http://issues.apache.org/jira/browse/SOLR-59 > Project: Solr > Issue Type: Improvement > Reporter: Bertrand Delacretaz > Attachments: SOLR-59-20061024.patch, SOLR-59-20061102.patch, > SOLR-59-new-files-20061102.tar.gz > > > This patch copies the request parameters (explicit ones only, not the > defaults) to Solr's XML output. > It is not configurable yet, it is enabled by default and adds a > "queryParameters" list to the responseHeader: > <responseHeader> > <status>0</status> > <QTime>1</QTime> > <lst name="queryParameters"> > <arr name="multi"> > <str>red</str> > <str>blue</str> > </arr> > <str name="rows">10</str> > <str name="start">0</str> > <str name="indent">on</str> > <str name="q">solr</str> > <str name="stylesheet"/> > <str name="version">2.1</str> > </lst> > </responseHeader> > The above example includes a multi-valued parameter, "multi". > This might still change a bit, but if someone wants to play with it or > improve it, here you go. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira