[ http://issues.apache.org/jira/browse/SOLR-65?page=comments#action_12447101 ] Mike Klaas commented on SOLR-65: --------------------------------
> The multithreaded stuff looks very nice! Thanks -- the new concurrent package is quite cool (it much better fits my mental model of thread synchro). About the closeWriter() -> absolutely correct. I had totally forgotten about the importance of opening a new searcher as part of the commit. 1) sounds good. 2) does this include explicit commits received? Might this make it tricky to test (both on solr's side and in userland)? Perhaps the default commit could be an absolute directive, but could accept an optional parameter that allows the commit to be cancelled by the intervalLowerBound parameter. Something like <commit hint="true"/>. Or it could be a new command <softcommit/>. autocommits would also fall into that category. 3) would this case be covered by the client sending an <add> followed by <softcommit/>? The on-the-fly tuning is possible for maxDocs autocommit but isn't practical for maxTime, since the time-based auto-commit is a system-wide property (whereas maxDocs are only checked within the context of a given request, so it is trivial to turn off checking locally). It might be better to have some sort of global parameter tuning possible here (jmx??). -Mike > autoCommit/autoOptimize implementation + multithreaded document adding > ---------------------------------------------------------------------- > > Key: SOLR-65 > URL: http://issues.apache.org/jira/browse/SOLR-65 > Project: Solr > Issue Type: New Feature > Components: update > Reporter: Mike Klaas > Assigned To: Mike Klaas > Attachments: autocommit_patch.diff > > > Basic implementation of autoCommit/autoOptimize functionality, plus overhaul > of DUH2 threading to reduce contention -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
