[ 
https://issues.apache.org/jira/browse/SOLR-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470110
 ] 

Ryan McKinley commented on SOLR-60:
-----------------------------------

As a note, there are no tests where 

  overwritePending != overwriteCommitted

In SOLR-139, the XmlUpdateRequestHandler maps all varitions of allowDups, 
overwriteCommitted and overwritePending  to a simpler 'overwrite' -- it throws 
an exception if overwritePending != overwriteCommitted.


> Remove overwritePending, overwriteCommitted flags?
> --------------------------------------------------
>
>                 Key: SOLR-60
>                 URL: https://issues.apache.org/jira/browse/SOLR-60
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>            Priority: Minor
>
> The overwritePending, overwriteCommitted, allowDups flags seem needlessly 
> complex and don't add much value.  Do people need/use separate control over 
> pending vs committed documents?
> Perhaps all most people need is overwrite=true/false?
> overwritePending, overwriteCommitted were originally added because it was a 
> (mis)feature that another internal search tool had.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to