Coda, I've been thinking about this over the weekend myself. I'm not
sure that packaging this as a rails plugin makes sense either. (Flare
certainly makes sense as a plugin.)
On the other hand, you mentioned issues around just unpacking gems to
vendor/ . If that's the case, I'd rather have a reliable plugin than
a semi-reliable unpacked gem. Any more info on that?
Jamie
On Feb 12, 2007, at 11:11 AM, Coda Hale (JIRA) wrote:
[ https://issues.apache.org/jira/browse/SOLR-154?
page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Coda Hale updated SOLR-154:
---------------------------
Attachment: solrb_vendor_package.diff
Here's an updated rake task for packaging solrb for use in the
vendor directory of a Rails project.
I disagree with Jamie's approach in making solrb a Rails plugin. It
doesn't modify or extend any of the Rails libraries, nor does it
even use libraries like ActiveSupport.
Placing it in the vendor directory (and adjusting the directory
structure so as to allow it to load with the same requires without
messing with the load path) seems like the best option to me.
Added package tasks for creating Rails plugin and namespaced both
the rails and gem packaging
---------------------------------------------------------------------
------------------------
Key: SOLR-154
URL: https://issues.apache.org/jira/browse/SOLR-154
Project: Solr
Issue Type: Improvement
Components: clients - ruby - flare
Environment: Ruby and Ruby on Rails
Reporter: Jamie Orchard-Hays
Attachments: Rakefile.diff, Rakefile_2.diff,
solrb_vendor_package.diff
Solrb's (sol.rb's?) rake file has a package:vendor task that is
not generating proper rails plugin structure. Rather than just fix
this, I've added a PackageTask to package up a proper Rails plugin
directory structure and also build distributable packages.
Included are the README, LICENSE.txt, and init.rb generated and
destroyed on the fly. Also, I've namespaced the Gem PackageTask
and the Rails PackageTask, so the commands:
rake rails:package (and repackage, clobber, clobber_package)
rake gem:package (and the rest...)
package their files up and dump them into pkg/rails and pkg/gem,
respectively. Their clobber tasks will only remove the sub-
directory under pkg/, not pkg/ itself.
rake package, rake repackage run both package tasks, while rake
clobber and rake clobber_package remove the complete pkg/ directory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
