[ 
https://issues.apache.org/jira/browse/SOLR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472904
 ] 

Hoss Man commented on SOLR-79:
------------------------------

I was going to chime in that unset properties should probably not default to an 
empty string:
  1) so that SOLR-109 would be more feasible
  2) so that we don't silently fail on typos

...looking at the latest patch, #1 isn't really an issue since $${literal} 
works ... but especially now that it's possible to specify a default value to 
use if they property isn't set: trying to use an unset property without a 
default specified should probably result in an exception ... correct?


as for my comment about system properties for testing: i was smoking crack 
thinking that the <syspropertyset> already in the build.xml junit target would 
magically take care of this for us, forgetting that somewhere the properties 
actually need to be set.


> [PATCH] Using system properties in Solr configuration
> -----------------------------------------------------
>
>                 Key: SOLR-79
>                 URL: https://issues.apache.org/jira/browse/SOLR-79
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Alexander Saar
>         Assigned To: Erik Hatcher
>            Priority: Minor
>         Attachments: solr-config-system-property.patch, 
> solr-config-system-property.patch, solr-config-system-property.patch, 
> solr-config-system-property.patch, solr-config-system-property.patch, 
> solr-config-system-property.patch
>
>
> Actually it is not possible to use system properties for configuring the Solr 
> engine. There should be a way of referencing system properties from 
> solrconfig.xml, like {$prop.name}.
> The attached patch will provide this feature.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to