[ 
https://issues.apache.org/jira/browse/SOLR-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473932
 ] 

Bertrand Delacretaz commented on SOLR-162:
------------------------------------------

I briefly tested this, it looks very useful, and the different RequestHandlers 
make the code very modular, way to go!

One nitpick: I'd use "system.properties" instead of "properties", it's more 
precise.

And two suggestions related to XSLT transformations for presentation:

1) It'd be good to systematically include in the output XML the class name of 
the SolrRequestHandler used. XSLT transforms can then use this info to adapt 
themselves to the information being output.

2) It'd be good to name <lst> elements, as much as possible, also to allow XSLT 
transforms to adapt themselves to the content.

For example, using a NamedList instead of an ArralyList in the "Now show all 
the threads" loop in ThreadDumpRequestHandler:

    NamedList<NamedList<Object>> lst = new NamedList<NamedList<Object>>();
    for (ThreadInfo ti : tinfos) {
      lst.add( "thread", getThreadInfo( ti ) );
    }

Outputs this:

<lst name="thread">
  <long name="id">35</long>
  <str name="name">P1-19</str>
  <str name="state">RUNNABLE</str>...

where the name="thread" attribute can be used to decide how to present the 
contents of the <lst> element.

Thinking about it, we might want to add a "datatype" attribute to these lists, 
to use when presenting them?

<lst datatype="java.lang.Thread">

would help present all Thread info in a consistent way, no matter where it 
comes from.



> lucene index browser / admin helpers (Luke)
> -------------------------------------------
>
>                 Key: SOLR-162
>                 URL: https://issues.apache.org/jira/browse/SOLR-162
>             Project: Solr
>          Issue Type: New Feature
>          Components: web gui
>            Reporter: Ryan McKinley
>            Priority: Minor
>         Attachments: SOLR-162-Admin-XML-luke.patch
>
>
> Luke (http://www.getopt.org/luke/) is a great tool to help learn / understand 
> / debug lucene indexes.
> Solr already does a lot of what luke does... but it could do a bit more.  
> Specifically:
> * browse top terms across all fields (similar to faceting)
> * browse lucene documents / properties directly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to