[
https://issues.apache.org/jira/browse/SOLR-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474316
]
Hoss Man commented on SOLR-85:
------------------------------
I have two reservcations about this patch...
1) duplicate code cut/paste from CommitRequestHandler in
XmlUpdateRequestHandler ... I agree that it would be nice if
XmlUpdateRequestHandler had that functionality, but it seems like it would be
better to either refactor it into a utility method, or make
XmlUpdateRequestHandler extend CommitRequestHandler and call
super.handleRequestBody at the end of it's own handleRequestBody.
2) the upload form assumes /update/xml is a registered requestHandler name
which is a bit brittle if people want to register it with a differnet name, and
also makes hte form fairly unusable if/when people register new update handlers
-- i'm sure yonik will polish his csv handler any day now :)
... a more reusable mechanism would probably be if instead of a simple
<enableUpload>true</enableUpload> we had something like...
<uploadFormHandlers>
<handler name="/update/xml">Upload XML</handler>
<handler name="/update/foo/bar/baz">Upload CSV</handler>
</uploadFormHandler
...admin.jsp would link to the upload form if any uploadHandlers/handler
entries exist .. and update.jsp would loop over all of them making a seperate
form for each.
> [PATCH] Add update form to the admin screen
> -------------------------------------------
>
> Key: SOLR-85
> URL: https://issues.apache.org/jira/browse/SOLR-85
> Project: Solr
> Issue Type: New Feature
> Components: update
> Reporter: Thorsten Scherler
> Attachments: solar-85.png, solar-85.png,
> solar-85.with.file.upload.diff, solar-85.with.file.upload.diff,
> solar-85.with.file.upload.diff, solar-85.with.file.upload.diff,
> solr-85-with-104.patch, solr-85-with-104.patch, solr-85-with-104.patch,
> solr-85.diff, solr-85.diff, solr-85.FINAL.diff
>
>
> It would be nice to have a webform to update solr via a http interface
> instead of using the post.sh.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
