[
https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478905
]
Ryan McKinley commented on SOLR-183:
------------------------------------
I agree it is a bit excessive... the thing that convinced me the hoops are ok
is getting a 400 exception rather then a 500 exception for:
int val = required.getInt( "hello" );
The hoops are ugly, but the result is that anything from the RequiredParams
will be valid - and throw a 400 exception if not. In my view, that is a
different enough "contract" to warrant a special class rather then adding more
functions to SolrParams.
All that said, simply adding getRequiredParam() to SolrParams is simple, clean
and solves most cases I'm worried about.
> add getRequiredParameter() to SolrParams
> ----------------------------------------
>
> Key: SOLR-183
> URL: https://issues.apache.org/jira/browse/SOLR-183
> Project: Solr
> Issue Type: Wish
> Reporter: Ryan McKinley
> Priority: Trivial
> Attachments: SOLR-183-required-param.patch,
> SOLR-183-required-param.patch
>
>
> I find myself including this with every patch, so i'll just separate it out.
> This simply adds a utilty function to SolrParams that throws a 400 if the
> parameter is missing:
> /** returns the value of the param, or throws a 400 exception if missing */
> public String getRequiredParameter(String param) throws SolrException {
> String val = get(param);
> if( val == null ) {
> throw new SolrException( 400, "Missing parameter: "+param );
> }
> return val;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
