Thanks for comments, Ryan. Took care of 2, 3, and 4. Should I really move the SpellCheckerRequestHandler to o.a.solr.handler instead? I see request handlers in both handler and request packages.
Otis . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . Simpy -- http://www.simpy.com/ - Tag - Search - Share ----- Original Message ---- From: Ryan McKinley <[EMAIL PROTECTED]> To: solr-dev@lucene.apache.org Sent: Sunday, March 18, 2007 8:41:20 PM Subject: Re: svn commit: r519107 - in /lucene/solr/trunk: CHANGES.txt example/exampledocs/spellchecher.xml example/solr/conf/solrconfig.xml lib/lucene-spellchecker-2.2-dev.jar src/java/org/apache/solr/request/SpellCheckerRequestHandler.java A few trivial comments on SpellCheckerRequestHandler: 1. Should it go in "org.apache.solr.handler" rather then "org.apache.solr.request"? As the number of special handlers increases, it seems good to have them semi-isolated. 2. replace tabs with two spaces 3. The file needs the svn props set 4. getVersion() should return "$Revision: 501512 $"; rather then SolrCore.version nit pick nit pick nit pick. otherwise looks good!
